[qcommon] Use unsigned types where wrapping arithmetic is intended

The use of signed types in these expressions lead to overflow, hence undefined behaviour. The "sum" aggregator in Com_TouchMemory isn't even used (and presumbably just exists to inhibit optimizations from removing the memory access).
This commit is contained in:
Thomas Köppe authored and Zack Middleton committed 2017-10-02 19:46:37 -05:00
1 parent a83ae01d93
commit b3223dcfcb
2 files changed
+2 -2

No files matched your search

+1 -1
View File
@@ -1376,7 +1376,7 @@ Touch all known used data to make sure it is paged in
void Com_TouchMemory( void ) {
int start, end;
int i, j;
int sum;
unsigned sum;
memblock_t *block;
Z_CheckHeap();
+1 -1
View File
@@ -148,7 +148,7 @@ vec3_t bytedirs[NUMVERTEXNORMALS] =
//==============================================================
int Q_rand( int *seed ) {
*seed = (69069 * *seed + 1);
*seed = (69069U * *seed + 1U);
return *seed;
}