Add string length checking to function COM_StripExtension. This fixes the R_RemapShader buffer overflow exploit that can be found here:
http://milw0rm.com/exploits/1750
This commit is contained in:
1 parent
2e368c02a6
commit
d21411452e
13 files changed
+22
-22
No files matched your search
@@ -85,7 +85,7 @@ static void UI_SaveConfigMenu_SaveEvent( void *ptr, int event ) {
|
||||
return;
|
||||
}
|
||||
|
||||
COM_StripExtension(saveConfig.savename.field.buffer, configname );
|
||||
COM_StripExtension(saveConfig.savename.field.buffer, configname, sizeof(configname));
|
||||
trap_Cmd_ExecuteText( EXEC_APPEND, va( "writeconfig %s.cfg\n", configname ) );
|
||||
UI_PopMenu();
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user