Version 4.5.0

applications/core/setup/upg_101100/upgrade.php

@@ -11,7 +11,7 @@
 namespace IPS\core\setup\upg_101100;
 
 /* To prevent PHP errors (extending class does not exist) revealing path */
-if ( !defined( '\IPS\SUITE_UNIQUE_KEY' ) )
+if ( !\defined( '\IPS\SUITE_UNIQUE_KEY' ) )
 {
 	header( ( isset( $_SERVER['SERVER_PROTOCOL'] ) ? $_SERVER['SERVER_PROTOCOL'] : 'HTTP/1.0' ) . ' 403 Forbidden' );
 	exit;
@@ -113,14 +113,14 @@ class _Upgrade
 		catch( \UnderflowException $e ) {}
 
 		/* Is this site affected by any of these issues? */
-		if( !count( $queries ) )
+		if( !\count( $queries ) )
 		{
 			return TRUE;
 		}
 
 		$toRun = \IPS\core\Setup\Upgrade::runManualQueries( $queries );
 
-		if ( count( $toRun ) )
+		if ( \count( $toRun ) )
 		{
 			\IPS\core\Setup\Upgrade::adjustMultipleRedirect( array( 1 => 'core', 'extra' => array( '_upgradeStep' => 3 ) ) );
 
@@ -208,7 +208,7 @@ class _Upgrade
 			$_SESSION['_step3Count'] = \IPS\Db::i()->select( 'COUNT(*)', 'core_dnames_change' )->first();
 		}
 
-		return "Moving Display Name history to the Member History system (Converted so far: " . ( ( $limit > $_SESSION['_step3Count'] ) ? $_SESSION['_step3Count'] : $limit ) . ' out of ' . $_SESSION['_step3Count'] . ')';
+		return "Converting display name history (Converted so far: " . ( ( $limit > $_SESSION['_step3Count'] ) ? $_SESSION['_step3Count'] : $limit ) . ' out of ' . $_SESSION['_step3Count'] . ')';
 	}
 	
 
@@ -299,7 +299,7 @@ class _Upgrade
 		{
 			$fileObj = \IPS\File::create( 'core_Reaction', "react_{$reaction}.png", file_get_contents( $path . "/install/reaction/react_{$reaction}.png" ), 'reactions', FALSE, NULL, FALSE );
 			$id = \IPS\Db::i()->insert( 'core_reactions', array(
-				'reaction_value'	=> ( in_array( $reaction, array( 'confused', 'sad' ) ) ) ? 0 : 1,
+				'reaction_value'	=> ( \in_array( $reaction, array( 'confused', 'sad' ) ) ) ? 0 : 1,
 				'reaction_icon'		=> (string) $fileObj,
 				'reaction_position'	=> ++$position,
 				'reaction_enabled'	=> ( \IPS\Settings::i()->reputation_point_types == 'like' ) ? 1 : 0,
@@ -443,7 +443,7 @@ class _Upgrade
 				break;
 		}
 
-		if ( count( $toRun ) )
+		if ( \count( $toRun ) )
 		{
 			\IPS\core\Setup\Upgrade::adjustMultipleRedirect( array( 1 => 'core', 'extra' => array( '_upgradeStep' => 9 ) ) );
 
@@ -606,7 +606,7 @@ class _Upgrade
 			$required[] = "core_pfield_{$row['pf_id']}";
 		}
 		
-		if ( count( $required ) )
+		if ( \count( $required ) )
 		{
 			$step						= new \IPS\Member\ProfileStep;
 			$step->required				= 1;
@@ -625,7 +625,7 @@ class _Upgrade
 			$optional[] = "core_pfield_{$row['pf_id']}";
 		}
 		
-		if ( count( $optional ) )
+		if ( \count( $optional ) )
 		{
 			$step						= new \IPS\Member\ProfileStep;
 			$step->required				= 0;
@@ -648,7 +648,7 @@ class _Upgrade
 	 */
 	public function step11CustomTitle()
 	{
-		return 'Setting up Profile Completion';
+		return 'Setting up profile completion';
 	}
 
 	/**
@@ -695,7 +695,7 @@ class _Upgrade
 
 		$toRun = \IPS\core\Setup\Upgrade::runManualQueries( array( $query ) );
 
-		if ( count( $toRun ) )
+		if ( \count( $toRun ) )
 		{
 			\IPS\core\Setup\Upgrade::adjustMultipleRedirect( array( 1 => 'core', 'extra' => array( '_upgradeStep' => 14 ) ) );