Version 5.0.0 beta 7

applications/convert/sources/Software/Forums/Woltlab.php

@@ -17,7 +17,7 @@ use DomainException;
 use Exception;
 use IPS\Content;
 use IPS\convert\Software;
-use IPS\convert\Software\Core\Woltlab;
+use IPS\convert\Software\Core\Woltlab as WoltlabCore;
 use IPS\Db;
 use IPS\Http\Url;
 use IPS\Member;
@@ -44,7 +44,7 @@ class Woltlab extends Software
 	/**
 	 * @brief	The WBB table prefix can change depending on the number of installs
 	 */
-	public static $installId = 1;
+	public static int $installId = 1;
 	
 	/**
 	 * Software Name
@@ -166,25 +166,23 @@ class Woltlab extends Software
 				{
 					throw new \IPS\convert\Exception( sprintf( Member::loggedIn()->language()->get( 'could_not_count_rows' ), $table ) );
 				}
-				break;
 
 			default:
 				return parent::countRows( $table, $where, $recache );
-				break;
 		}
 	}
 
 	/**
 	 * Pre-process content for the Invision Community text parser
 	 *
-	 * @param	string			The post
-	 * @param	string|null		Content Classname passed by post-conversion rebuild
-	 * @param	int|null		Content ID passed by post-conversion rebuild
+	 * @param	string $post The post
+	 * @param	string|null $className Content Classname passed by post-conversion rebuild
+	 * @param	int|null $contentId Content ID passed by post-conversion rebuild
 	 * @return	string			The converted post
 	 */
 	public static function fixPostData( string $post, ?string $className=null, ?int $contentId=null ): string
 	{
-		return Woltlab::fixPostData( $post, $className, $contentId );
+		return WoltlabCore::fixPostData( $post, $className, $contentId );
 	}
 
 	/**
@@ -263,7 +261,7 @@ class Woltlab extends Software
 	 *
 	 * @return	void
 	 */
-	public function convertForumsForums()
+	public function convertForumsForums() : void
 	{
 		$libraryClass = $this->getLibrary();
 		$libraryClass::setKey( 'boardID' );
@@ -316,7 +314,7 @@ class Woltlab extends Software
 	 *
 	 * @return	void
 	 */
-	public function convertForumsTopics()
+	public function convertForumsTopics() : void
 	{
 		$libraryClass = $this->getLibrary();
 		$libraryClass::setKey( 'threadID' );
@@ -388,7 +386,7 @@ class Woltlab extends Software
 	 *
 	 * @return	void
 	 */
-	public function convertForumsPosts()
+	public function convertForumsPosts() : void
 	{
 		$libraryClass = $this->getLibrary();
 		$libraryClass::setKey( 'postID' );
@@ -438,7 +436,7 @@ class Woltlab extends Software
 	 *
 	 * @return	void
 	 */
-	public function convertAttachments()
+	public function convertAttachments() : void
 	{
 		$libraryClass = $this->getLibrary();
 		$libraryClass::setKey( 'attachmentID' );