Version 4.6.0

system/3rd_party/graphql-php/Validator/Rules/NoUnusedVariables.php

@@ -1,20 +1,19 @@
 <?php
+
+declare(strict_types=1);
+
 namespace GraphQL\Validator\Rules;
 
 use GraphQL\Error\Error;
 use GraphQL\Language\AST\NodeKind;
 use GraphQL\Language\AST\OperationDefinitionNode;
+use GraphQL\Language\AST\VariableDefinitionNode;
 use GraphQL\Validator\ValidationContext;
+use function sprintf;
 
-class NoUnusedVariables extends AbstractValidationRule
+class NoUnusedVariables extends ValidationRule
 {
-    static function unusedVariableMessage($varName, $opName = null)
-    {
-        return $opName
-            ? "Variable \"$$varName\" is never used in operation \"$opName\"."
-            : "Variable \"$$varName\" is never used.";
-    }
-
+    /** @var VariableDefinitionNode[] */
     public $variableDefs;
 
     public function getVisitor(ValidationContext $context)
@@ -23,34 +22,45 @@ class NoUnusedVariables extends AbstractValidationRule
 
         return [
             NodeKind::OPERATION_DEFINITION => [
-                'enter' => function() {
+                'enter' => function () : void {
                     $this->variableDefs = [];
                 },
-                'leave' => function(OperationDefinitionNode $operation) use ($context) {
+                'leave' => function (OperationDefinitionNode $operation) use ($context) : void {
                     $variableNameUsed = [];
-                    $usages = $context->getRecursiveVariableUsages($operation);
-                    $opName = $operation->name ? $operation->name->value : null;
+                    $usages           = $context->getRecursiveVariableUsages($operation);
+                    $opName           = $operation->name !== null
+                        ? $operation->name->value
+                        : null;
 
                     foreach ($usages as $usage) {
-                        $node = $usage['node'];
+                        $node                                 = $usage['node'];
                         $variableNameUsed[$node->name->value] = true;
                     }
 
                     foreach ($this->variableDefs as $variableDef) {
                         $variableName = $variableDef->variable->name->value;
 
-                        if (empty($variableNameUsed[$variableName])) {
-                            $context->reportError(new Error(
-                                self::unusedVariableMessage($variableName, $opName),
-                                [$variableDef]
-                            ));
+                        if ($variableNameUsed[$variableName] ?? false) {
+                            continue;
                         }
+
+                        $context->reportError(new Error(
+                            self::unusedVariableMessage($variableName, $opName),
+                            [$variableDef]
+                        ));
                     }
-                }
+                },
             ],
-            NodeKind::VARIABLE_DEFINITION => function($def) {
+            NodeKind::VARIABLE_DEFINITION  => function ($def) : void {
                 $this->variableDefs[] = $def;
-            }
+            },
         ];
     }
+
+    public static function unusedVariableMessage($varName, $opName = null)
+    {
+        return $opName
+            ? sprintf('Variable "$%s" is never used in operation "%s".', $varName, $opName)
+            : sprintf('Variable "$%s" is never used.', $varName);
+    }
 }