Version 5.0.0 beta 4

applications/convert/sources/Software/Gallery/Coppermine.php

@@ -37,9 +37,9 @@ class Coppermine extends Software
 	/**
 	 * Software Name
 	 *
-	 * @return	string
+	 * @return    string
 	 */
-	public static function softwareName()
+	public static function softwareName(): string
 	{
 		/* Child classes must override this method */
 		return "Coppermine (phpBB 3.1.x/3.2.x)";
@@ -48,9 +48,9 @@ class Coppermine extends Software
 	/**
 	 * Software Key
 	 *
-	 * @return	string
+	 * @return    string
 	 */
-	public static function softwareKey()
+	public static function softwareKey(): string
 	{
 		/* Child classes must override this method */
 		return "coppermine";
@@ -59,9 +59,9 @@ class Coppermine extends Software
 	/**
 	 * Content we can convert from this software.
 	 *
-	 * @return	array
+	 * @return    array|null
 	 */
-	public static function canConvert()
+	public static function canConvert(): ?array
 	{
 		return array(
 			'convertGalleryCategories'	=> array(
@@ -86,9 +86,9 @@ class Coppermine extends Software
 	/**
 	 * Possible Parent Conversions
 	 *
-	 * @return	NULL|array
+	 * @return    array|NULL
 	 */
-	public static function parents()
+	public static function parents(): ?array
 	{
 		return array( 'core' => array( 'phpbb' ) );
 	}
@@ -96,9 +96,9 @@ class Coppermine extends Software
 	/**
 	 * List of conversion methods that require additional information
 	 *
-	 * @return	array
+	 * @return    array
 	 */
-	public static function checkConf()
+	public static function checkConf(): array
 	{
 		return array(
 			'convertGalleryAlbums',
@@ -109,10 +109,10 @@ class Coppermine extends Software
 	/**
 	 * Get More Information
 	 *
-	 * @param	string	$method	Method name
-	 * @return	array
+	 * @param string $method	Method name
+	 * @return    array|null
 	 */
-	public function getMoreInfo( $method )
+	public function getMoreInfo( string $method ): ?array
 	{
 		$return = array();
 		switch( $method )
@@ -152,9 +152,9 @@ class Coppermine extends Software
 	/**
 	 * Finish - Adds everything it needs to the queues and clears data store
 	 *
-	 * @return	array		Messages to display
+	 * @return    array        Messages to display
 	 */
-	public function finish()
+	public function finish(): array
 	{
 		/* Content Rebuilds */
 		Task::queue( 'convert', 'RebuildGalleryImages', array( 'app' => $this->app->app_id ), 2, array( 'app' ) );
@@ -174,7 +174,7 @@ class Coppermine extends Software
 	 *
 	 * @return	void
 	 */
-	public function convertGalleryCategories()
+	public function convertGalleryCategories() : void
 	{
 		$libraryClass = $this->getLibrary();
 
@@ -199,7 +199,7 @@ class Coppermine extends Software
 	 *
 	 * @return	void
 	 */
-	public function convertGalleryAlbums()
+	public function convertGalleryAlbums() : void
 	{
 		$libraryClass = $this->getLibrary();
 
@@ -209,7 +209,7 @@ class Coppermine extends Software
 		{
 			$info = array(
 				'album_id'					=> $row['aid'],
-				'album_owner_id'			=> isset( $row['owner'] ) ? $row['owner'] : NULL,
+				'album_owner_id'			=> $row['owner'] ?? NULL,
 				'album_category_id'			=> $row['category'],
 				'album_description'			=> $row['description'],
 				'album_position'			=> $row['pos'],
@@ -243,7 +243,7 @@ class Coppermine extends Software
 	 *
 	 * @return	void
 	 */
-	public function convertGalleryImages()
+	public function convertGalleryImages() : void
 	{
 		$libraryClass = $this->getLibrary();
 
@@ -303,7 +303,7 @@ class Coppermine extends Software
 	 *
 	 * @return	void
 	 */
-	public function convertGalleryComments()
+	public function convertGalleryComments() : void
 	{
 		$libraryClass = $this->getLibrary();