Version 4.7.23

applications/downloads/sources/File/PendingVersion.php

@@ -325,6 +325,7 @@ class _PendingVersion extends \IPS\Content\Item implements \IPS\Content\Hideable
 	public function delete()
 	{
 		$ids = [];
+		/* @note SELECT_FROM_WRITE_SERVER added in pull #6913 "We update record_hidden=0 then delete record_hidden=1 pretty quickly afterwards before the change had propagated to the reader." */
 		foreach( \IPS\Db::i()->select( '*', 'downloads_files_records', [ 'record_file_id=? AND record_hidden=1', $this->file_id ], NULL, NULL, NULL, NULL, \IPS\Db::SELECT_FROM_WRITE_SERVER ) as $record )
 		{
 			switch( $record['record_type'] )
@@ -402,11 +403,13 @@ class _PendingVersion extends \IPS\Content\Item implements \IPS\Content\Hideable
 			catch( \Exception $e ){}
 		}
 
+		/* @note SELECT_FROM_WRITE_SERVER race condition */
 		$file->size = \floatval( \IPS\Db::i()->select( 'SUM(record_size)', 'downloads_files_records', array( 'record_file_id=? AND record_type=? AND record_backup=0', $file->id, 'upload' ), NULL, NULL, NULL, NULL, \IPS\Db::SELECT_FROM_WRITE_SERVER )->first() );
 
 		/* Work out the new primary screenshot */
 		try
 		{
+			/* @note SELECT_FROM_WRITE_SERVER race condition */
 			$file->primary_screenshot = \IPS\Db::i()->select( 'record_id', 'downloads_files_records', array( 'record_file_id=? AND ( record_type=? OR record_type=? ) AND record_backup=0 AND record_hidden=0', $file->id, 'ssupload', 'sslink' ), 'record_default DESC, record_id ASC', NULL, NULL, NULL, \IPS\Db::SELECT_FROM_WRITE_SERVER )->first();
 		}
 		catch ( \UnderflowException $e ) { }