Version 5.0.0 beta 1

applications/nexus/widgets/bestSellers.php

@@ -12,43 +12,50 @@
 namespace IPS\nexus\widgets;
 
 /* To prevent PHP errors (extending class does not exist) revealing path */
-if ( !\defined( '\IPS\SUITE_UNIQUE_KEY' ) )
+
+use IPS\Db;
+use IPS\Helpers\Form;
+use IPS\Helpers\Form\Number;
+use IPS\Member;
+use IPS\Output;
+use IPS\Patterns\ActiveRecordIterator;
+use IPS\Theme;
+use IPS\Widget\Customizable;
+use IPS\Widget\PermissionCache;
+use function defined;
+
+if ( !defined( '\IPS\SUITE_UNIQUE_KEY' ) )
 {
-	header( ( isset( $_SERVER['SERVER_PROTOCOL'] ) ? $_SERVER['SERVER_PROTOCOL'] : 'HTTP/1.0' ) . ' 403 Forbidden' );
+	header( ( $_SERVER['SERVER_PROTOCOL'] ?? 'HTTP/1.0' ) . ' 403 Forbidden' );
 	exit;
 }
 
 /**
  * bestSellers Widget
  */
-class _bestSellers extends \IPS\Widget\PermissionCache
+class bestSellers extends PermissionCache implements Customizable
 {
 	/**
 	 * @brief	Widget Key
 	 */
-	public $key = 'bestSellers';
+	public string $key = 'bestSellers';
 	
 	/**
 	 * @brief	App
 	 */
-	public $app = 'nexus';
-		
-	/**
-	 * @brief	Plugin
-	 */
-	public $plugin = '';
+	public string $app = 'nexus';
 	
 	/**
 	 * Init widget
 	 *
-	 * @return	null
+	 * @return	void
 	 */
-	public function init()
+	public function init(): void
 	{
-		\IPS\Output::i()->cssFiles = array_merge( 
-			\IPS\Output::i()->cssFiles, 
-			\IPS\Theme::i()->css( 'widgets.css', 'nexus' ), 
-			\IPS\Theme::i()->css( 'store.css', 'nexus' ) 
+		Output::i()->cssFiles = array_merge(
+			Output::i()->cssFiles,
+			Theme::i()->css( 'widgets.css', 'nexus' ),
+			Theme::i()->css( 'store.css', 'nexus' )
 		);
 
 		parent::init();
@@ -57,14 +64,14 @@ class _bestSellers extends \IPS\Widget\PermissionCache
 	/**
 	 * Specify widget configuration
 	 *
-	 * @param	null|\IPS\Helpers\Form	$form	Form object
-	 * @return	null|\IPS\Helpers\Form
+	 * @param	null|Form	$form	Form object
+	 * @return	Form
 	 */
-	public function configuration( &$form=null )
+	public function configuration( ?Form &$form=null ): Form
 	{
 		$form = parent::configuration( $form );
 
-		$form->add( new \IPS\Helpers\Form\Number( 'number_to_show', isset( $this->configuration['number_to_show'] ) ? $this->configuration['number_to_show'] : 5, TRUE ) );
+		$form->add( new Number( 'number_to_show', $this->configuration['number_to_show'] ?? 5, TRUE ) );
 
 		return $form;
  	} 
@@ -75,7 +82,7 @@ class _bestSellers extends \IPS\Widget\PermissionCache
  	 * @param	array	$values	Values from form
  	 * @return	array
  	 */
- 	public function preConfig( $values )
+ 	public function preConfig( array $values ): array
  	{
  		return $values;
  	}
@@ -85,12 +92,12 @@ class _bestSellers extends \IPS\Widget\PermissionCache
 	 *
 	 * @return	string
 	 */
-	public function render()
+	public function render(): string
 	{
 		$packages = array();
-		$purchases = \IPS\Db::i()->select( 'count(*) as purchased, ps_item_id', 'nexus_purchases', array(
+		$purchases = Db::i()->select( 'count(*) as purchased, ps_item_id', 'nexus_purchases', array(
 			array( 'p_store=1' ),
-			array( "( p_member_groups='*' OR " . \IPS\Db::i()->findInSet( 'p_member_groups', \IPS\Member::loggedIn()->groups ) . ' )' )
+			array( "( p_member_groups='*' OR " . Db::i()->findInSet( 'p_member_groups', Member::loggedIn()->groups ) . ' )' )
 		), 'purchased DESC', array( 0, ( isset( $this->configuration['number_to_show'] ) AND $this->configuration['number_to_show'] > 0 ) ? $this->configuration['number_to_show'] : 5 ), 'ps_item_id' )
 			->join( 'nexus_packages', array( "ps_item_id=p_id") );
 
@@ -104,7 +111,7 @@ class _bestSellers extends \IPS\Widget\PermissionCache
 			return "";
 		}
 
-		$packages = new \IPS\Patterns\ActiveRecordIterator( \IPS\Db::i()->select( '*', 'nexus_packages', array( \IPS\Db::i()->in( 'p_id', $packages ) ) ), 'IPS\nexus\Package' );
+		$packages = new ActiveRecordIterator( Db::i()->select( '*', 'nexus_packages', array( Db::i()->in( 'p_id', $packages ) ) ), 'IPS\nexus\Package' );
 
 		return $this->output( $packages );
 	}