Version 5.0.0 beta 1

applications/gallery/extensions/core/AdvertisementLocations/ImageLightbox.php

@@ -12,16 +12,20 @@
 namespace IPS\gallery\extensions\core\AdvertisementLocations;
 
 /* To prevent PHP errors (extending class does not exist) revealing path */
-if ( !\defined( '\IPS\SUITE_UNIQUE_KEY' ) )
+
+use IPS\Extensions\AdvertisementLocationsAbstract;
+use function defined;
+
+if ( !defined( '\IPS\SUITE_UNIQUE_KEY' ) )
 {
-	header( ( isset( $_SERVER['SERVER_PROTOCOL'] ) ? $_SERVER['SERVER_PROTOCOL'] : 'HTTP/1.0' ) . ' 403 Forbidden' );
+	header( ( $_SERVER['SERVER_PROTOCOL'] ?? 'HTTP/1.0' ) . ' 403 Forbidden' );
 	exit;
 }
 
 /**
  * Advertisement locations extension
  */
-class _ImageLightbox
+class ImageLightbox extends AdvertisementLocationsAbstract
 {
 	/** 
 	 * Get the locations and the additional settings
@@ -29,7 +33,7 @@ class _ImageLightbox
 	 * @param	array	$settings	Current setting values
 	 * @return	array	Array with two elements: 'locations' which should have keys as the location keys and values as the fields to toggle, and 'settings' which are additional fields to add to the form
 	 */
-	public function getSettings( $settings )
+	public function getSettings( array $settings ): array
 	{
 		return array( 'locations' => array( 'ad_image_lightbox' => array() ), 'settings' => array() );
 	}
@@ -40,7 +44,7 @@ class _ImageLightbox
 	 * @param	array	$values	Values from the form submission
 	 * @return	array 	Array of setting key => value to store
 	 */
-	public function parseSettings( $values )
+	public function parseSettings( array $values ): array
 	{
 		return array();
 	}