Version 5.0.0 beta 1

applications/forums/api/GraphQL/Queries/Topic.php

@@ -10,25 +10,29 @@
  */
 
 namespace IPS\forums\api\GraphQL\Queries;
-use GraphQL\Type\Definition\ObjectType;
+use IPS\Api\GraphQL\SafeException;
 use IPS\Api\GraphQL\TypeRegistry;
+use IPS\forums\api\GraphQL\Types\TopicType;
+use IPS\forums\Topic as TopicClass;
+use OutOfRangeException;
+use function defined;
 
 /* To prevent PHP errors (extending class does not exist) revealing path */
-if ( !\defined( '\IPS\SUITE_UNIQUE_KEY' ) )
+if ( !defined( '\IPS\SUITE_UNIQUE_KEY' ) )
 {
-	header( ( isset( $_SERVER['SERVER_PROTOCOL'] ) ? $_SERVER['SERVER_PROTOCOL'] : 'HTTP/1.0' ) . ' 403 Forbidden' );
+	header( ( $_SERVER['SERVER_PROTOCOL'] ?? 'HTTP/1.0' ) . ' 403 Forbidden' );
 	exit;
 }
 
 /**
  * Topic query for GraphQL API
  */
-class _Topic
+class Topic
 {
 	/*
 	 * @brief 	Query description
 	 */
-	public static $description = "Returns a topic";
+	public static string $description = "Returns a topic";
 
 	/*
 	 * Query arguments
@@ -42,8 +46,10 @@ class _Topic
 
 	/**
 	 * Return the query return type
+	 *
+	 * @return TopicType
 	 */
-	public function type() 
+	public function type() : TopicType
 	{
 		return \IPS\forums\api\GraphQL\TypeRegistry::topic();
 	}
@@ -51,25 +57,26 @@ class _Topic
 	/**
 	 * Resolves this query
 	 *
-	 * @param 	mixed 	Value passed into this resolver
-	 * @param 	array 	Arguments
-	 * @param 	array 	Context values
-	 * @return	\IPS\forums\Topic\Post
+	 * @param 	mixed $val 	Value passed into this resolver
+	 * @param 	array $args 	Arguments
+	 * @param 	array $context 	Context values
+	 * @param	array $info
+	 * @return	TopicClass
 	 */
-	public function resolve($val, $args, $context, $info)
+	public function resolve( mixed $val, array $args, array $context, array $info ) : TopicClass
 	{
 		try
 		{
-			$topic = \IPS\forums\Topic::loadAndCheckPerms( $args['id'] );
+			$topic = TopicClass::loadAndCheckPerms( $args['id'] );
 		}
-		catch ( \OutOfRangeException $e )
+		catch ( OutOfRangeException $e )
 		{
-			throw new \IPS\Api\GraphQL\SafeException( 'NO_TOPIC', '1F294/2_graphql', 400 );
+			throw new SafeException( 'NO_TOPIC', '1F294/2_graphql', 400 );
 		}
 
 		if( !$topic->can('read') )
 		{
-			throw new \IPS\Api\GraphQL\SafeException( 'INVALID_ID', '2F294/9_graphql', 403 );
+			throw new SafeException( 'INVALID_ID', '2F294/9_graphql', 403 );
 		}
 
 		return $topic;