Version 5.0.0 beta 1

applications/core/api/GraphQL/Queries/OurPicks.php

@@ -10,25 +10,30 @@
  */
 
 namespace IPS\core\api\GraphQL\Queries;
-use GraphQL\Type\Definition\ObjectType;
+use GraphQL\Type\Definition\ListOfType;
 use IPS\Api\GraphQL\TypeRegistry;
+use IPS\core\api\GraphQL\Types\PromotedItemType;
+use IPS\core\Feature;
+use function count;
+use function defined;
+use function is_int;
 
 /* To prevent PHP errors (extending class does not exist) revealing path */
-if ( !\defined( '\IPS\SUITE_UNIQUE_KEY' ) )
+if ( !defined( '\IPS\SUITE_UNIQUE_KEY' ) )
 {
-	header( ( isset( $_SERVER['SERVER_PROTOCOL'] ) ? $_SERVER['SERVER_PROTOCOL'] : 'HTTP/1.0' ) . ' 403 Forbidden' );
+	header( ( $_SERVER['SERVER_PROTOCOL'] ?? 'HTTP/1.0' ) . ' 403 Forbidden' );
 	exit;
 }
 
 /**
  * OurPicks query for GraphQL API
  */
-class _OurPicks
+class OurPicks
 {
 	/*
 	 * @brief 	Query description
 	 */
-	public static $description = "Returns promoted items";
+	public static string $description = "Returns promoted items";
 
 	/*
 	 * Query arguments
@@ -42,8 +47,10 @@ class _OurPicks
 
 	/**
 	 * Return the query return type
+	 *
+	 * @return ListOfType<PromotedItemType>
 	 */
-	public function type() 
+	public function type() : ListOfType
 	{
 		return TypeRegistry::listOf( \IPS\core\api\GraphQL\TypeRegistry::promotedItem() );
 	}
@@ -51,21 +58,21 @@ class _OurPicks
 	/**
 	 * Resolves this query
 	 *
-	 * @param 	mixed 	Value passed into this resolver
-	 * @param 	array 	Arguments
-	 * @param 	array 	Context values
-	 * @return	\IPS\core\Stream
+	 * @param mixed $val Value passed into this resolver
+	 * @param array $args Arguments
+	 * @param array $context Context values
+	 * @return	array|null
 	 */
-	public function resolve($val, $args, $context)
+	public function resolve( mixed $val, array $args, array $context ) : ?array
 	{
 		$limit = 7;
-		if( isset( $args['count'] ) && \is_int( $args['count'] ) )
+		if( isset( $args['count'] ) && is_int( $args['count'] ) )
 		{
 			$limit = $args['count'];
 		}
 
-		$items = \IPS\core\Promote::internalStream( $limit );
-		if( !\count( $items ) )
+		$items = Feature::internalStream( $limit );
+		if( !count( $items ) )
 		{
 			return NULL;
 		}