Version 5.0.0 beta 1

applications/core/api/GraphQL/Mutations/DeleteAttachment.php

@@ -10,25 +10,32 @@
  */
 
 namespace IPS\core\api\GraphQL\Mutations;
-use GraphQL\Type\Definition\ObjectType;
+use Exception;
+use GraphQL\Type\Definition\BooleanType;
+use IPS\Api\GraphQL\SafeException;
 use IPS\Api\GraphQL\TypeRegistry;
+use IPS\Db;
+use IPS\File;
+use IPS\Member;
+use UnderflowException;
+use function defined;
 
 /* To prevent PHP errors (extending class does not exist) revealing path */
-if ( !\defined( '\IPS\SUITE_UNIQUE_KEY' ) )
+if ( !defined( '\IPS\SUITE_UNIQUE_KEY' ) )
 {
-	header( ( isset( $_SERVER['SERVER_PROTOCOL'] ) ? $_SERVER['SERVER_PROTOCOL'] : 'HTTP/1.0' ) . ' 403 Forbidden' );
+	header( ( $_SERVER['SERVER_PROTOCOL'] ?? 'HTTP/1.0' ) . ' 403 Forbidden' );
 	exit;
 }
 
 /**
  * Delete attachment mutation for GraphQL API
  */
-class _DeleteAttachment
+class DeleteAttachment
 {
 	/*
 	 * @brief 	Query description
 	 */
-	public static $description = "Delete an attachment";
+	public static string $description = "Delete an attachment";
 	
 	/*
 	 * Mutation arguments
@@ -46,8 +53,10 @@ class _DeleteAttachment
 	
 	/**
 	 * Return the mutation return type
+	 *
+	 * @return BooleanType
 	 */
-	public function type() 
+	public function type() : BooleanType
 	{
 		return TypeRegistry::boolean();
 	}
@@ -55,21 +64,22 @@ class _DeleteAttachment
 	/**
 	 * Resolves this mutation
 	 *
-	 * @param 	mixed 	Value passed into this resolver
-	 * @param 	array 	Arguments
-	 * @param 	array 	Context values
+	 * @param mixed $val Value passed into this resolver
+	 * @param array $args Arguments
+	 * @param array $context Context values
+	 * @param array $info
 	 * @return	bool
 	 */
-	public function resolve($val, $args, $context, $info)
+	public function resolve( mixed $val, array $args, array $context, array $info ) : bool
 	{
 		/* Get the attachment */
 		try
 		{				
-			$attachment = \IPS\Db::i()->select( '*', 'core_attachments', array( 'attach_id=?', $args['id'] ) )->first();
+			$attachment = Db::i()->select( '*', 'core_attachments', array( 'attach_id=?', $args['id'] ) )->first();
 		}
-		catch ( \UnderflowException $e )
+		catch ( UnderflowException $e )
 		{
-			throw new \IPS\Api\GraphQL\SafeException( 'NO_ATTACHMENT', 'GQL/0004/1', 404 );
+			throw new SafeException( 'NO_ATTACHMENT', 'GQL/0004/1', 404 );
 		}
 				
 		/* Delete the maps - Only do this for attachments that have actually been saved (if they haven't been saved, there's nothing in core_attachments_map for us to delete */
@@ -85,34 +95,34 @@ class _DeleteAttachment
 				}
 			}
 
-			\IPS\Db::i()->delete( 'core_attachments_map', $where );
+			Db::i()->delete( 'core_attachments_map', $where );
 		}
 		else
 		{
 			/* If the attachment hasn't been claimed yet, it should only be deletable by the person who uploaded it */
-			if( $attachment['attach_member_id'] != \IPS\Member::loggedIn()->member_id )
+			if( $attachment['attach_member_id'] != Member::loggedIn()->member_id )
 			{
-				throw new \IPS\Api\GraphQL\SafeException( 'CANNOT_DELETE_OTHERS_ATTACHMENTS', 'GQL/0004/2', 403 );
+				throw new SafeException( 'CANNOT_DELETE_OTHERS_ATTACHMENTS', 'GQL/0004/2', 403 );
 			}
 		}
 		
 		/* If there's no other maps, we can delete the attachment itself */
-		$otherMaps = \IPS\Db::i()->select( 'COUNT(*)', 'core_attachments_map', array( 'attachment_id=?', $attachment['attach_id'] ) )->first();
+		$otherMaps = Db::i()->select( 'COUNT(*)', 'core_attachments_map', array( 'attachment_id=?', $attachment['attach_id'] ) )->first();
 		if ( !$otherMaps )
 		{
-			\IPS\Db::i()->delete( 'core_attachments', array( 'attach_id=?', $attachment['attach_id'] ) );
+			Db::i()->delete( 'core_attachments', array( 'attach_id=?', $attachment['attach_id'] ) );
 			try
 			{
-				\IPS\File::get( 'core_Attachment', $attachment['attach_location'] )->delete();
+				File::get( 'core_Attachment', $attachment['attach_location'] )->delete();
 			}
-			catch ( \Exception $e ) { }
+			catch ( Exception $e ) { }
 			if ( $attachment['attach_thumb_location'] )
 			{
 				try
 				{
-					\IPS\File::get( 'core_Attachment', $attachment['attach_thumb_location'] )->delete();
+					File::get( 'core_Attachment', $attachment['attach_thumb_location'] )->delete();
 				}
-				catch ( \Exception $e ) { }
+				catch ( Exception $e ) { }
 			}
 		}