Version 5.0.0 beta 1

applications/convert/extensions/core/Queue/RebuildFirstPostIds.php

@@ -12,30 +12,43 @@
 namespace IPS\convert\extensions\core\Queue;
 
 /* To prevent PHP errors (extending class does not exist) revealing path */
-if ( !\defined( '\IPS\SUITE_UNIQUE_KEY' ) )
+
+use Exception;
+use IPS\Application;
+use IPS\Db;
+use IPS\forums\Topic\ArchivedPost;
+use IPS\Member;
+use IPS\Patterns\ActiveRecordIterator;
+use IPS\Task\Queue\OutOfRangeException;
+use UnderflowException;
+use function count;
+use function defined;
+use const IPS\REBUILD_SLOW;
+
+if ( !defined( '\IPS\SUITE_UNIQUE_KEY' ) )
 {
-	header( ( isset( $_SERVER['SERVER_PROTOCOL'] ) ? $_SERVER['SERVER_PROTOCOL'] : 'HTTP/1.0' ) . ' 403 Forbidden' );
+	header( ( $_SERVER['SERVER_PROTOCOL'] ?? 'HTTP/1.0' ) . ' 403 Forbidden' );
 	exit;
 }
 
 /**
  * Background Task
  */
-class _RebuildFirstPostIds
+class RebuildFirstPostIds
 {
 	/**
 	 * Parse data before queuing
 	 *
 	 * @param	array	$data	Data
-	 * @return	array
+	 * @return	array|null
 	 */
-	public function preQueueData( $data )
+	public function preQueueData( array $data ): ?array
 	{
 		try
 		{
-			$data['count'] = \IPS\Db::i()->select( 'count(tid)', 'forums_topics' )->first();
+			$data['count'] = Db::i()->select( 'count(tid)', 'forums_topics' )->first();
 		}
-		catch( \Exception $e )
+		catch( Exception $e )
 		{
 			throw new \OutOfRangeException;
 		}
@@ -56,13 +69,13 @@ class _RebuildFirstPostIds
 	 * @param	mixed						$data	Data as it was passed to \IPS\Task::queue()
 	 * @param	int							$offset	Offset
 	 * @return	int							New offset
-	 * @throws	\IPS\Task\Queue\OutOfRangeException	Indicates offset doesn't exist and thus task is complete
+	 * @throws	OutOfRangeException	Indicates offset doesn't exist and thus task is complete
 	 */
-	public function run( &$data, $offset )
+	public function run( mixed &$data, int $offset ): int
 	{
-		if ( !class_exists( 'IPS\forums\Topic' ) OR !\IPS\Application::appisEnabled( 'forums' ) )
+		if ( !class_exists( 'IPS\forums\Topic' ) OR !Application::appisEnabled( 'forums' ) )
 		{
-			throw new \IPS\Task\Queue\OutOfRangeException;
+			throw new OutOfRangeException;
 		}
 
 		$last = NULL;
@@ -72,14 +85,14 @@ class _RebuildFirstPostIds
 		$firstPostIds				= array();
 		$firstPostArchivedIds		= array();
 
-		foreach( new \IPS\Patterns\ActiveRecordIterator( \IPS\Db::i()->select( '*', 'forums_topics', array( "tid>?", $offset ), "tid ASC", array( 0, \IPS\REBUILD_SLOW ) ), 'IPS\forums\Topic' ) AS $topic )
+		foreach( new ActiveRecordIterator( Db::i()->select( '*', 'forums_topics', array( "tid>?", $offset ), "tid ASC", array( 0, REBUILD_SLOW ) ), 'IPS\forums\Topic' ) AS $topic )
 		{
 			if ( $topic->isArchived() == FALSE )
 			{
 				try
 				{
 					/* Set first post */
-					$topic->topic_firstpost = \IPS\Db::i()->select( 'pid', 'forums_posts', array( 'topic_id=?', $topic->tid ), 'post_date ASC', 1 )->first();
+					$topic->topic_firstpost = Db::i()->select( 'pid', 'forums_posts', array( 'topic_id=?', $topic->tid ), 'post_date ASC', 1 )->first();
 					$topic->save();
 
 					/* Reset new_topic value for topic */
@@ -87,14 +100,14 @@ class _RebuildFirstPostIds
 					$firstPostIds[]		= $topic->topic_firstpost;
 				}
 				/* Underflow exception may occur if the topic doesn't have any posts for an unknown reason */
-				catch( \UnderflowException $e ) {}
+				catch( UnderflowException $e ) {}
 			}
 			else
 			{
 				try
 				{
 					/* Set first post */
-					$topic->topic_firstpost = \IPS\forums\Topic\ArchivedPost::db()->select( 'archive_id', 'forums_archive_posts', array( "archive_topic_id=?", $topic->tid ), "archive_content_date ASC", 1 )->first();
+					$topic->topic_firstpost = ArchivedPost::db()->select( 'archive_id', 'forums_archive_posts', array( "archive_topic_id=?", $topic->tid ), "archive_content_date ASC", 1 )->first();
 					$topic->save();
 
 					/* Reset new_topic value for topic */
@@ -102,7 +115,7 @@ class _RebuildFirstPostIds
 					$firstPostArchivedIds[]		= $topic->topic_firstpost;
 				}
 				/* Underflow exception may occur if the topic doesn't have any posts for an unknown reason */
-				catch( \UnderflowException $e ) {}
+				catch( UnderflowException $e ) {}
 			}
 
 			$last = $topic->tid;
@@ -110,29 +123,29 @@ class _RebuildFirstPostIds
 		}
 
 		/* Reset flags as needed */
-		if( \count( $topicIdsToReset ) )
+		if( count( $topicIdsToReset ) )
 		{
-			\IPS\Db::i()->update( 'forums_posts', array( 'new_topic' => 0 ), array( 'topic_id IN(' . implode( ',', $topicIdsToReset ) . ')' ) );
+			Db::i()->update( 'forums_posts', array( 'new_topic' => 0 ), array( 'topic_id IN(' . implode( ',', $topicIdsToReset ) . ')' ) );
 		}
 
-		if( \count( $firstPostIds ) )
+		if( count( $firstPostIds ) )
 		{
-			\IPS\Db::i()->update( 'forums_posts', array( 'new_topic' => 1 ), array( 'pid IN(' . implode( ',', $firstPostIds ) . ')' ) );
+			Db::i()->update( 'forums_posts', array( 'new_topic' => 1 ), array( 'pid IN(' . implode( ',', $firstPostIds ) . ')' ) );
 		}
 
-		if( \count( $archivedTopicIdsToReset ) )
+		if( count( $archivedTopicIdsToReset ) )
 		{
-			\IPS\forums\Topic\ArchivedPost::db()->update( 'forums_archive_posts', array( 'archive_is_first' => 0 ), array( 'archive_topic_id IN(' . implode( ',', $archivedTopicIdsToReset ) . ')' ) );
+			ArchivedPost::db()->update( 'forums_archive_posts', array( 'archive_is_first' => 0 ), array( 'archive_topic_id IN(' . implode( ',', $archivedTopicIdsToReset ) . ')' ) );
 		}
 
-		if( \count( $firstPostArchivedIds ) )
+		if( count( $firstPostArchivedIds ) )
 		{
-			\IPS\forums\Topic\ArchivedPost::db()->update( 'forums_archive_posts', array( 'archive_is_first' => 1 ), array( 'archive_id IN(' . implode( ',', $firstPostArchivedIds ) . ')' ) );
+			ArchivedPost::db()->update( 'forums_archive_posts', array( 'archive_is_first' => 1 ), array( 'archive_id IN(' . implode( ',', $firstPostArchivedIds ) . ')' ) );
 		}
 
 		if( $last === NULL )
 		{
-			throw new \IPS\Task\Queue\OutOfRangeException;
+			throw new OutOfRangeException;
 		}
 
 		return $last;
@@ -145,8 +158,8 @@ class _RebuildFirstPostIds
 	 * @param	int						$offset	Offset
 	 * @return	array	Text explaining task and percentage complete
 	 */
-	public function getProgress( $data, $offset )
+	public function getProgress( mixed $data, int $offset ): array
 	{
-		return array( 'text' =>  \IPS\Member::loggedIn()->language()->addToStack('queue_rebuilding_new_topic_flag'), 'complete' => $data['count'] ? ( round( 100 / $data['count'] * $data['completed'], 2 ) ) : 100 );
+		return array( 'text' =>  Member::loggedIn()->language()->addToStack('queue_rebuilding_new_topic_flag'), 'complete' => $data['count'] ? ( round( 100 / $data['count'] * $data['completed'], 2 ) ) : 100 );
 	}
 }